Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 42610: Fix and cleanup ARM port:... (Closed)

Created:
11 years, 9 months ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Fix and cleanup ARM port: 1) removed unused function, PcStoreOffset; 2) use macro instruction, Jump, when branching from JS code to C code. This CL replaces http://codereview.chromium.org/53039/show, per our discussion. Committed: http://code.google.com/p/v8/source/detail?r=1614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M src/assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/assembler-arm.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
iposva
11 years, 9 months ago (2009-03-25 18:18:10 UTC) #1
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698