Issue 42606: Making google update UAC prompt launch in the foreground

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42606: Making google update UAC prompt launch in the foreground (Closed)

Created:
11 years, 9 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal, ananta

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Passing a foreground window to the google update code so that if it triggers UAC prompts, they can launch in the foreground. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12554

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -10 lines)			Patch
M	chrome/browser/google_update.h	View	1 2	3 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/google_update.cc	View	1 2	6 chunks	+19 lines, -6 lines	0 comments	Download
M	chrome/browser/views/about_chrome_view.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

robertshield

Hey Ananta, It looks like kuchhal is on vacation, would you mind taking a look ...

11 years, 9 months ago (2009-03-26 14:25:55 UTC) #2

LGTM