Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4609)

Unified Diff: chrome/browser/google_update.h

Issue 42606: Making google update UAC prompt launch in the foreground (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google_update.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_update.h
===================================================================
--- chrome/browser/google_update.h (revision 12286)
+++ chrome/browser/google_update.h (working copy)
@@ -12,6 +12,9 @@
#include "google_update_idl.h"
class MessageLoop;
+namespace views {
+class Window;
+}
// The status of the upgrade. UPGRADE_STARTED and UPGRADE_CHECK_STARTED are
// internal states and will not be reported as results to the listener.
@@ -84,7 +87,10 @@
// Ask Google Update to see if a new version is available. If the parameter
// |install_if_newer| is true then Google Update will also install that new
// version.
- void CheckForUpdate(bool install_if_newer);
+ // |window| should point to a foreground window. This is needed to ensure
+ // that Vista/Windows 7 UAC prompts show up in the foreground. It may also
+ // be null.
+ void CheckForUpdate(bool install_if_newer, views::Window* window);
// Adds/removes a listener to report status back to. Only one listener is
// maintained at the moment.
@@ -95,7 +101,10 @@
// We need to run the update check on another thread than the main thread, and
// therefore CheckForUpdate will delegate to this function. |main_loop| points
// to the message loop that we want the response to come from.
- bool InitiateGoogleUpdateCheck(bool install_if_newer, MessageLoop* main_loop);
+ // |window| should point to a foreground window. This is needed to ensure that
+ // Vista/Windows 7 UAC prompts show up in the foreground. It may also be null.
+ bool InitiateGoogleUpdateCheck(bool install_if_newer, views::Window* window,
+ MessageLoop* main_loop);
// This function reports the results of the GoogleUpdate operation to the
// listener. If results indicates an error, the error_code will indicate which
« no previous file with comments | « no previous file | chrome/browser/google_update.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698