Issue 42560: Strcmp thinko and SConstruct improvement for d8 on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42560: Strcmp thinko and SConstruct improvement for d8 on Android. (Closed)

Created:
11 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Strcmp thinko and SConstruct improvement for d8 on Android. Committed: http://code.google.com/p/v8/source/detail?r=1601

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	SConstruct	View		1 chunk	+14 lines, -0 lines	1 comment	Download
	M	src/d8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-24 14:14:41 UTC) #2

LGTM

http://codereview.chromium.org/42560/diff/1/3
File SConstruct (right):

http://codereview.chromium.org/42560/diff/1/3#newcode390
Line 390: 'LIBPATH':     [ANDROID_TOP + '/out/target/product/generic/obj/lib'],
How about defining ANDROID_LINKFLAGS like ANDROID_FLAGS and ANDROID_INCLUDES?
They look the same for shell sample and d8.

Expand Messages | Collapse Messages