Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: src/d8.cc

Issue 42560: Strcmp thinko and SConstruct improvement for d8 on Android. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« SConstruct ('K') | « SConstruct ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 i::OS::MemoryMappedFile* Shell::counters_file_ = NULL; 90 i::OS::MemoryMappedFile* Shell::counters_file_ = NULL;
91 CounterCollection Shell::local_counters_; 91 CounterCollection Shell::local_counters_;
92 CounterCollection* Shell::counters_ = &local_counters_; 92 CounterCollection* Shell::counters_ = &local_counters_;
93 Persistent<Context> Shell::utility_context_; 93 Persistent<Context> Shell::utility_context_;
94 Persistent<Context> Shell::evaluation_context_; 94 Persistent<Context> Shell::evaluation_context_;
95 95
96 96
97 bool CounterMap::Match(void* key1, void* key2) { 97 bool CounterMap::Match(void* key1, void* key2) {
98 const char* name1 = reinterpret_cast<const char*>(key1); 98 const char* name1 = reinterpret_cast<const char*>(key1);
99 const char* name2 = reinterpret_cast<const char*>(key2); 99 const char* name2 = reinterpret_cast<const char*>(key2);
100 return strcmp(name1, name2) != 0; 100 return strcmp(name1, name2) == 0;
101 } 101 }
102 102
103 103
104 // Converts a V8 value to a C string. 104 // Converts a V8 value to a C string.
105 const char* ToCString(const v8::String::Utf8Value& value) { 105 const char* ToCString(const v8::String::Utf8Value& value) {
106 return *value ? *value : "<string conversion failed>"; 106 return *value ? *value : "<string conversion failed>";
107 } 107 }
108 108
109 109
110 // Executes a string within the current v8 context. 110 // Executes a string within the current v8 context.
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 return 0; 664 return 0;
665 } 665 }
666 666
667 667
668 } // namespace v8 668 } // namespace v8
669 669
670 670
671 int main(int argc, char* argv[]) { 671 int main(int argc, char* argv[]) {
672 return v8::Shell::Main(argc, argv); 672 return v8::Shell::Main(argc, argv);
673 } 673 }
OLDNEW
« SConstruct ('K') | « SConstruct ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698