Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/make.py

Issue 42394: Cleanup remove mac specific type 'application'... (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/generator/msvs.py » ('j') | pylib/gyp/generator/xcode.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/make.py
===================================================================
--- pylib/gyp/generator/make.py (revision 374)
+++ pylib/gyp/generator/make.py (working copy)
@@ -213,7 +213,7 @@
deps = libs
# Now write the actual build rule.
- if typ in ('executable', 'application'):
+ if typ == 'executable':
fp.write('%s: $(OBJS) %s\n' % (output, ' '.join(deps)))
fp.write('\t$(call do_cmd,link)\n')
binpath = '$(obj)/bin/' + target
@@ -259,7 +259,7 @@
fp.write('\tmkdir -p %s\n' % ' '.join(dirs))
fp.write('\t%s\n' % ' '.join(action['action']))
- if typ not in ('executable', 'application', 'resource', 'none', 'static_library'):
+ if typ not in ('executable', 'resource', 'none', 'static_library'):
raise "unhandled typ", typ
fp.write('\n')
« no previous file with comments | « no previous file | pylib/gyp/generator/msvs.py » ('j') | pylib/gyp/generator/xcode.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698