Fix some UI issues with omnibox extensions in incognito.

Fix some UI issues with omnibox extensions in incognito.

Also moved a shared method from ExtensionEventRouter to ExtensionsService.

BUG=58210
TEST=Install the extension in chrome/common/extensions/docs/examples/extensions/chrome_search. You should not see the UI artifacts described in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64964

[Matt Perry, 2010-11-03 00:02:59]

Peter: please review */autocomplete/*
Antony: the other stuff

http://codereview.chromium.org/4234004/diff/1/3
File chrome/browser/autocomplete/keyword_provider.cc (left):

http://codereview.chromium.org/4234004/diff/1/3#oldcode225
chrome/browser/autocomplete/keyword_provider.cc:225:
matches_.push_back(CreateAutocompleteMatch(model, keyword, input,
Note: I moved this up because at line 208, we rely on this first match's
relevance score.

[asargent_no_longer_on_chrome, 2010-11-03 00:12:42]

extensions parts lgtm

[Peter Kasting, 2010-11-03 17:27:15]

LGTM

http://codereview.chromium.org/4234004/diff/1/2
File chrome/browser/autocomplete/autocomplete_popup_model.cc (right):

http://codereview.chromium.org/4234004/diff/1/2#newcode224
chrome/browser/autocomplete/autocomplete_popup_model.cc:224: // Don't provide a
hint if this is an extension keyword not enabled for this
Nit: "...not enabled in incognito mode" is probably better.

http://codereview.chromium.org/4234004/diff/1/3
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/4234004/diff/1/3#newcode172
chrome/browser/autocomplete/keyword_provider.cc:172: // Prune any extension
keywords for disabled or unprivileged extensions.
Nit: What does "disabled or unprivileged" mean?  It looks as if this is just
"When in incognito mode, prune any keywords for extensions that are not enabled
for incognito mode".  And if that's true, perhaps the profile->IsOffTheRecord()
check should be hoisted to cover this whole block?

http://codereview.chromium.org/4234004/diff/1/3#newcode183
chrome/browser/autocomplete/keyword_provider.cc:183: if (!enabled) {
Nit: Just eliminate |enabled| and roll the code into this statement.

[Matt Perry, 2010-11-03 19:34:14]

http://codereview.chromium.org/4234004/diff/1/2
File chrome/browser/autocomplete/autocomplete_popup_model.cc (right):

http://codereview.chromium.org/4234004/diff/1/2#newcode224
chrome/browser/autocomplete/autocomplete_popup_model.cc:224: // Don't provide a
hint if this is an extension keyword not enabled for this
On 2010/11/03 17:27:15, Peter Kasting wrote:
> Nit: "...not enabled in incognito mode" is probably better.

Done.

http://codereview.chromium.org/4234004/diff/1/3
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/4234004/diff/1/3#newcode172
chrome/browser/autocomplete/keyword_provider.cc:172: // Prune any extension
keywords for disabled or unprivileged extensions.
On 2010/11/03 17:27:15, Peter Kasting wrote:
> Nit: What does "disabled or unprivileged" mean?  It looks as if this is just
> "When in incognito mode, prune any keywords for extensions that are not
enabled
> for incognito mode".  And if that's true, perhaps the
profile->IsOffTheRecord()
> check should be hoisted to cover this whole block?

it's (disabled) || (extensions not enabled for incognito mode if we're in
incognito mode). I had a hard time thinking of a concise way to say that.