chrome/browser/extensions/extension_function_dispatcher.cc - Issue 4234004: Fix some UI issues with omnibox extensions in incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 4234004: Fix some UI issues with omnibox extensions in incognito. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_dispatcher.cc

diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc

index 783a8bf0ad0cdc62e3bac3099fbafd59c8637afa..d402962efe358453f0dde3cb86b52b0c885c6ed4 100644

--- a/chrome/browser/extensions/extension_function_dispatcher.cc

+++ b/chrome/browser/extensions/extension_function_dispatcher.cc

@@ -450,8 +450,7 @@ void ExtensionFunctionDispatcher::HandleRequest(

DCHECK(service);

const Extension* extension = service->GetExtensionById(extension_id(), false);

DCHECK(extension);

- function->set_include_incognito(service->IsIncognitoEnabled(extension) &&

- !extension->incognito_split_mode());

+ function->set_include_incognito(service->CanCrossIncognito(extension));

if (!service->ExtensionBindingsAllowed(function->source_url()) ||

!extension->HasApiPermission(function->name())) {