Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 42329: Getting rid of OS::StrDup and OS::StrNDup which were sometimes misused. (Closed)

Created:
11 years, 9 months ago by olehougaard
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Getting rid of OS::StrDup and OS::StrNDup which were sometimes misused. Committed: http://code.google.com/p/v8/source/detail?r=1534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -82 lines) Patch
M src/platform.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M test/cctest/cctest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
olehougaard
11 years, 9 months ago (2009-03-18 12:37:58 UTC) #1
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-18 12:41:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698