Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: src/platform-macos.cc

Issue 42329: Getting rid of OS::StrDup and OS::StrNDup which were sometimes misused. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform-linux.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-macos.cc
===================================================================
--- src/platform-macos.cc (revision 1525)
+++ src/platform-macos.cc (working copy)
@@ -202,28 +202,6 @@
}
-char* OS::StrDup(const char* str) {
- return strdup(str);
-}
-
-
-char* OS::StrNDup(const char* str, size_t n) {
- // Stupid implementation of strndup since macos isn't born with
- // one.
- size_t len = strlen(str);
- if (len <= n) {
- return StrDup(str);
- }
- char* result = new char[n+1];
- size_t i;
- for (i = 0; i <= n; i++) {
- result[i] = str[i];
- }
- result[i] = '\0';
- return result;
-}
-
-
// We keep the lowest and highest addresses mapped as a quick way of
// determining that pointers are outside the heap (used mostly in assertions
// and verification). The estimate is conservative, ie, not all addresses in
« no previous file with comments | « src/platform-linux.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698