Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 42324: Add a bit to a virtual frame element telling if it's been copied. Set... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a bit to a virtual frame element telling if it's been copied. Set it when a copy is made, clear it when the element is next written. Committed: http://code.google.com/p/v8/source/detail?r=1529

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M src/virtual-frame.h View 4 chunks +18 lines, -9 lines 1 comment Download
M src/virtual-frame.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/virtual-frame-ia32.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-18 10:21:58 UTC) #1
Erik Corry
LGTM despite the comment. http://codereview.chromium.org/42324/diff/1/2 File src/virtual-frame.h (right): http://codereview.chromium.org/42324/diff/1/2#newcode107 Line 107: type_ = (type_ & ...
11 years, 9 months ago (2009-03-18 10:31:02 UTC) #2
William Hesse
11 years, 9 months ago (2009-03-18 10:34:54 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698