Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 4229006: Revert 64888 - Push for ers:... (Closed)

Created:
10 years, 1 month ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
Charlie Lee
CC:
chromium-reviews, ben+cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 64888 - Push for ers: Added handling of network ("service" in flimflam parlance) property changes. NetworkLibrary updates its Network objects in response to property changes, then calls any NetworkObservers that have registered for the given network. Use the is_active member of Network in various places to ensure that we are dealing with the correct network. Created separate observer classes for NetworkManager, Network, and CellularDataPlan, so that monitors can be established independently for each of them. Changed the callback method names to prepend "On", i.e., OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. Wired up signal strength update and network technology update in the status bar, network dropdown menu, and internet settings page. Added new icon badges for 1xRTT radio technology. These are used when EVDO coverage switches to 1xRTT. Just as is the case for the 3G icons, there are three 1x icons: normal, warn, and error. Please consider these icons to be placeholders if the UI folks think they need to be redesigned. Centralized choosing of the network technology badge in NetworkMenu::BadgeForNetworkTechnology. BUG=chromium-os:5612 :chromium-os:7619,chromium-os:5917,chromium-os:4674 TEST=Extensive manual testing with different combinations of wi-fi and cellular networks connected and disconnected. Used a modified version of flimflam that randomly changes reported signal strength, network technology, and roaming state, and verified that the UI correctly reflected current values for the active network (roaming is not handled in the UI at this time). Review URL: http://codereview.chromium.org/4235005 TBR=chocobo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -832 lines) Patch
D chrome/app/theme/statusbar_network_1x.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_1x_error.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_1x_warn.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/mock_network_library.h View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 10 chunks +30 lines, -80 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 23 chunks +126 lines, -363 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/internet_options_handler.h View 3 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/internet_options_handler.cc View 4 chunks +8 lines, -52 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc View 6 chunks +43 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 8 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/network_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/network_list.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/network_message_observer.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/network_message_observer.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/network_state_notifier.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/network_state_notifier.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/chromeos/network_state_notifier_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/internet_page_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/internet_page_view.cc View 4 chunks +19 lines, -16 lines 0 comments Download
MM chrome/browser/chromeos/status/network_dropdown_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/network_dropdown_button.cc View 3 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 2 chunks +3 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.h View 4 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.cc View 5 chunks +64 lines, -101 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Charlie Lee
10 years, 1 month ago (2010-11-03 06:58:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698