Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 4229006: Revert 64888 - Push for ers:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/network_screen_browsertest.cc
===================================================================
--- chrome/browser/chromeos/login/network_screen_browsertest.cc (revision 64888)
+++ chrome/browser/chromeos/login/network_screen_browsertest.cc (working copy)
@@ -88,13 +88,10 @@
EXPECT_CALL(*mock_network_library_, Connecting())
.Times(2)
.WillRepeatedly(Return(false));
+ // Add an AddObserver for prewarming auth url check.
EXPECT_CALL(*mock_network_library_, AddObserver(_))
.Times(3);
EXPECT_CALL(*mock_network_library_, RemoveObserver(_))
- // Add an Observer for prewarming auth url check.
- EXPECT_CALL(*mock_network_library_, AddNetworkManagerObserver(_))
- .Times(3);
- EXPECT_CALL(*mock_network_library_, RemoveNetworkManagerObserver(_))
.Times(2);
cros_mock_->SetStatusAreaMocksExpectations();
@@ -150,7 +147,7 @@
EXPECT_CALL(*mock_network_library_, ethernet_connecting())
.WillOnce((Return(true)));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
@@ -159,7 +156,7 @@
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(true));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_TRUE(network_view->IsContinueEnabled());
EmulateContinueButtonExit(network_screen);
@@ -189,7 +186,7 @@
EXPECT_CALL(*mock_network_library_, wifi_network())
.WillOnce(Return(wifi.get()));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
@@ -198,7 +195,7 @@
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(true));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_TRUE(network_view->IsContinueEnabled());
EmulateContinueButtonExit(network_screen);
@@ -230,7 +227,7 @@
EXPECT_CALL(*mock_network_library_, cellular_network())
.WillOnce(Return(cellular.get()));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
@@ -239,7 +236,7 @@
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(true));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_TRUE(network_view->IsContinueEnabled());
EmulateContinueButtonExit(network_screen);
@@ -271,7 +268,7 @@
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(false));
- network_screen->OnNetworkManagerChanged(mock_network_library_);
+ network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/login/network_screen_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698