SSLPolicy Fix: Step 6....

SSLPolicy Fix: Step 6.

Merge in changes to SSLHostState.  We now can store whether a specific origin is "broken," which is the key new bit of state that we need to share between tabs.

Currently, there is a naming inconsistency between the SSLManager names and the SSLHostState names.  I'll clear this up when I merge in the new SSLManager.

R=jcampan
BUG=8706
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11891

[abarth-chromium, 2009-03-17 10:25:44]

We're getting closer to the meat of the change.

[jcampan, 2009-03-17 17:54:31]

LGTM

some nits

http://codereview.chromium.org/42274/diff/1/3
File chrome/browser/ssl/ssl_host_state.cc (right):

http://codereview.chromium.org/42274/diff/1/3#newcode62
Line 62: return cert_policy_for_host_[host].HasAllowedCert();
So if there is no entry for |host| in |cert_policy_for_host_| it'll create a new
one which by default returns false in HasAllowedCert? Wouldn't it make the code
easier to read if you were checking and returning false if there is no policy
for |host| in |cert_policy_for_host_|?

http://codereview.chromium.org/42274/diff/1/4
File chrome/browser/ssl/ssl_host_state.h (right):

http://codereview.chromium.org/42274/diff/1/4#newcode20
Line 20: // example, SSLHostState rememebers whether the user has whitelisted a
Nit: rememebers -> remembers

http://codereview.chromium.org/42274/diff/1/4#newcode30
Line 30: // Record that a host is "broken," that is, the origin for that host
has been
Nit: Record -> Records

http://codereview.chromium.org/42274/diff/1/4#newcode52
Line 52: // Allow mixed content to be visible (non filtered).
Nit: Allow -> Allows

[abarth-chromium, 2009-03-17 18:04:48]

http://codereview.chromium.org/42274/diff/1/3
File chrome/browser/ssl/ssl_host_state.cc (right):

http://codereview.chromium.org/42274/diff/1/3#newcode62
Line 62: return cert_policy_for_host_[host].HasAllowedCert();
Fixed.

http://codereview.chromium.org/42274/diff/1/4
File chrome/browser/ssl/ssl_host_state.h (right):

http://codereview.chromium.org/42274/diff/1/4#newcode20
Line 20: // example, SSLHostState rememebers whether the user has whitelisted a
Fixed.

http://codereview.chromium.org/42274/diff/1/4#newcode30
Line 30: // Record that a host is "broken," that is, the origin for that host
has been
Fixed.

http://codereview.chromium.org/42274/diff/1/4#newcode52
Line 52: // Allow mixed content to be visible (non filtered).
Fixed.

[jcampan, 2009-03-17 18:50:58]

LGTM