Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/ssl/ssl_host_state.cc

Issue 42274: SSLPolicy Fix: Step 6.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_host_state.h ('k') | chrome/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_host_state.cc
===================================================================
--- chrome/browser/ssl/ssl_host_state.cc (revision 11853)
+++ chrome/browser/ssl/ssl_host_state.cc (working copy)
@@ -6,12 +6,40 @@
#include "base/logging.h"
+namespace {
+
+static const char kDot = '.';
+
+static bool IsIntranetHost(const std::string& host) {
+ const size_t dot = host.find(kDot);
+ return dot == std::string::npos || dot == host.length() - 1;
+}
+
+} // namespace
+
SSLHostState::SSLHostState() {
}
SSLHostState::~SSLHostState() {
}
+void SSLHostState::MarkHostAsBroken(const std::string& host) {
+ DCHECK(CalledOnValidThread());
+
+ broken_hosts_.insert(host);
+}
+
+bool SSLHostState::DidMarkHostAsBroken(const std::string& host) {
+ DCHECK(CalledOnValidThread());
+
+ // CAs issue certificate for intranet hosts to everyone. Therefore, we always
+ // treat intranet hosts as broken.
+ if (IsIntranetHost(host))
+ return true;
+
+ return (broken_hosts_.find(host) != broken_hosts_.end());
+}
+
void SSLHostState::DenyCertForHost(net::X509Certificate* cert,
const std::string& host) {
DCHECK(CalledOnValidThread());
@@ -28,6 +56,18 @@
cert_policy_for_host_[host].Allow(cert);
}
+bool SSLHostState::DidAllowCertForHost(const std::string& host) {
+ DCHECK(CalledOnValidThread());
+
+ std::map<std::string, net::X509Certificate::Policy>::const_iterator iter =
+ cert_policy_for_host_.find(host);
+
+ if (iter == cert_policy_for_host_.end())
+ return false;
+
+ return iter->second.HasAllowedCert();
+}
+
net::X509Certificate::Policy::Judgment SSLHostState::QueryPolicy(
net::X509Certificate* cert, const std::string& host) {
DCHECK(CalledOnValidThread());
@@ -35,15 +75,15 @@
return cert_policy_for_host_[host].Check(cert);
}
-bool SSLHostState::CanShowInsecureContent(const GURL& url) {
+void SSLHostState::AllowMixedContentForHost(const std::string& host) {
DCHECK(CalledOnValidThread());
- return (can_show_insecure_content_for_host_.find(url.host()) !=
- can_show_insecure_content_for_host_.end());
+ allow_mixed_content_for_host_.insert(host);
}
-void SSLHostState::AllowShowInsecureContentForURL(const GURL& url) {
+bool SSLHostState::DidAllowMixedContentForHost(const std::string& host) {
DCHECK(CalledOnValidThread());
- can_show_insecure_content_for_host_.insert(url.host());
+ return (allow_mixed_content_for_host_.find(host) !=
+ allow_mixed_content_for_host_.end());
}
« no previous file with comments | « chrome/browser/ssl/ssl_host_state.h ('k') | chrome/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698