Ensure that a listener's OnChannelConnected is called before OnMessageReceive...

Ensure that a listener's OnChannelConnected is called before OnMessageReceived.

A race condition existed since the listener thread could dispatch messages in two ways: a task being posted to it, or because the dispatch messages event is set.  The latter is needed to avoid deadlock when multiple SyncChannels are used on the same listener thread.  If the latter method was used to dispatch a message, it might occur before the task that calls OnChannelConnected gets run.

The fix is to call OnChannelConnected manually if we notice a message is being dispatched before it's called.

Note: I couldn't think of a way to test this since it depends on a race condition in the listener message looop (whether the task or objectwatcher gets run first).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11522

[darin (slow to review), 2009-03-12 06:44:10]

LGTM

can you think of a way that we might change ChannelProxy to make that kind of
test possible?