Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3805)

Unified Diff: chrome/common/ipc_channel_proxy.h

Issue 42113: Ensure that a listener's OnChannelConnected is called before OnMessageReceive... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/ipc_channel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/ipc_channel_proxy.h
===================================================================
--- chrome/common/ipc_channel_proxy.h (revision 11508)
+++ chrome/common/ipc_channel_proxy.h (working copy)
@@ -138,9 +138,11 @@
MessageLoop* ipc_thread);
virtual ~Context() { }
MessageLoop* ipc_message_loop() const { return ipc_message_loop_; }
- Channel::Listener* listener() const { return listener_; }
const std::wstring& channel_id() const { return channel_id_; }
+ // Dispatches a message on the listener thread.
+ void OnDispatchMessage(const Message& message);
+
protected:
// IPC::Channel::Listener methods:
virtual void OnMessageReceived(const Message& message);
@@ -172,8 +174,7 @@
void OnSendMessage(Message* message_ptr);
void OnAddFilter(MessageFilter* filter);
void OnRemoveFilter(MessageFilter* filter);
- void OnDispatchMessage(const Message& message);
- void OnDispatchConnected(int32 peer_pid);
+ void OnDispatchConnected();
void OnDispatchError();
MessageLoop* listener_message_loop_;
@@ -184,6 +185,8 @@
MessageLoop* ipc_message_loop_;
Channel* channel_;
std::wstring channel_id_;
+ int peer_pid_;
+ bool channel_connected_called_;
};
Context* context() { return context_; }
« no previous file with comments | « no previous file | chrome/common/ipc_channel_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698