Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 42013: Slight code change to make some global variables const. (Closed)

Created:
11 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Slight code change to make some global variables const. Fix >80 cols lines. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -186 lines) Patch
M chrome/tools/build/win/dependencies.py View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/tools/crash_service/crash_service.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/bitmap_scroll_bar.h View 1 chunk +16 lines, -9 lines 0 comments Download
M chrome/views/bitmap_scroll_bar.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/views/chrome_menu.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/views/combo_box.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/event.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/views/grid_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/grid_layout_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/views/label.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/native_scroll_bar.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/views/painter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/views/text_button.cc View 1 chunk +35 lines, -20 lines 0 comments Download
M chrome/views/tooltip_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/views/widget_win.h View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/views/window.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M chrome/worker/webworkerclient_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/worker/worker_thread.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/completion_callback.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/cookie_policy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/data_url_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/base/escape_unittest.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M net/base/mime_sniffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/mime_util.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/base/net_util_unittest.cc View 6 chunks +26 lines, -12 lines 0 comments Download
M net/base/nss_memio.c View 4 chunks +13 lines, -13 lines 0 comments Download
M net/base/ssl_client_socket_nss.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/telnet_server.h View 1 chunk +18 lines, -9 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/http/http_chunked_decoder_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_response_headers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/testserver/testserver.py View 19 chunks +46 lines, -21 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 chunk +16 lines, -10 lines 0 comments Download
M net/url_request/url_request_job_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/sandbox_poc/pocdll/invasive.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/src/service_resolver.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M sandbox/tools/finder/stdafx.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/tools/launcher/stdafx.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 9 months ago (2009-03-10 14:43:33 UTC) #1
Nicolas Sylvain
11 years, 9 months ago (2009-03-10 16:50:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698