Slight code change to make some global variables const.

net/base/net_util_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/net_util.h"
@@ skipping 98 matching lines @@
   return ai;
 }
 
 }  // anonymous namespace
 
 TEST(NetUtilTest, FileURLConversion) {
   // a list of test file names and the corresponding URLs
   const FileCase round_trip_cases[] = {
 #if defined(OS_WIN)
     {L"C:\\foo\\bar.txt", L"file:///C:/foo/bar.txt"},
-    {L"\\\\some computer\\foo\\bar.txt", L"file://some%20computer/foo/bar.txt"}, // UNC
-    {L"D:\\Name;with%some symbols*#", L"file:///D:/Name%3Bwith%25some%20symbols*%23"},
-    {L"D:\\Chinese\\\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc", L"file:///D:/Chinese/%E6%89%80%E6%9C%89%E4%B8%AD%E6%96%87%E7%BD%91%E9%A1%B5.doc"},
+    {L"\\\\some computer\\foo\\bar.txt",
+     L"file://some%20computer/foo/bar.txt"}, // UNC
+    {L"D:\\Name;with%some symbols*#",
+     L"file:///D:/Name%3Bwith%25some%20symbols*%23"},
+    {L"D:\\Chinese\\\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc",
+     L"file:///D:/Chinese/%E6%89%80%E6%9C%89%E4%B8%AD%E6%96%87%E7%BD%91"
+         L"%E9%A1%B5.doc"},
 #elif defined(OS_POSIX)
     {L"/foo/bar.txt", L"file:///foo/bar.txt"},
     {L"/foo/BAR.txt", L"file:///foo/BAR.txt"},
     {L"/C:/foo/bar.txt", L"file:///C:/foo/bar.txt"},
     {L"/some computer/foo/bar.txt", L"file:///some%20computer/foo/bar.txt"},
     {L"/Name;with%some symbols*#", L"file:///Name%3Bwith%25some%20symbols*%23"},
-    {L"/Chinese/\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc", L"file:///Chinese/%E6%89%80%E6%9C%89%E4%B8%AD%E6%96%87%E7%BD%91%E9%A1%B5.doc"},
+    {L"/Chinese/\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc",
+     L"file:///Chinese/%E6%89%80%E6%9C%89%E4%B8%AD%E6%96%87%E7%BD"
+         L"%91%E9%A1%B5.doc"},
 #endif
   };
 
   // First, we'll test that we can round-trip all of the above cases of URLs
   std::wstring output;
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(round_trip_cases); i++) {
     // convert to the file URL
     GURL file_url(net::FilePathToFileURL(round_trip_cases[i].file));
     EXPECT_EQ(std::wstring(round_trip_cases[i].url),
               UTF8ToWide(file_url.spec()));
@@ skipping 38 matching lines @@
 #endif
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(url_cases); i++) {
     net::FileURLToFilePath(GURL(WideToUTF8(url_cases[i].url)), &output);
     EXPECT_EQ(std::wstring(url_cases[i].file), output);
   }
 
   // Here, we test that UTF-8 encoded strings get decoded properly, even when
   // they might be stored with wide characters.  On posix systems, just treat
   // this as a stream of bytes.
-  const wchar_t utf8[] = L"file:///d:/Chinese/\xe6\x89\x80\xe6\x9c\x89\xe4\xb8\xad\xe6\x96\x87\xe7\xbd\x91\xe9\xa1\xb5.doc";
+  const wchar_t utf8[] = L"file:///d:/Chinese/\xe6\x89\x80\xe6\x9c\x89\xe4\xb8"
+                         L"\xad\xe6\x96\x87\xe7\xbd\x91\xe9\xa1\xb5.doc";
 #if defined(OS_WIN)
-  const wchar_t wide[] = L"D:\\Chinese\\\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc";
+  const wchar_t wide[] =
+      L"D:\\Chinese\\\x6240\x6709\x4e2d\x6587\x7f51\x9875.doc";
 #elif defined(OS_POSIX)
-  const wchar_t wide[] = L"/d:/Chinese/\xe6\x89\x80\xe6\x9c\x89\xe4\xb8\xad\xe6\x96\x87\xe7\xbd\x91\xe9\xa1\xb5.doc";
+  const wchar_t wide[] = L"/d:/Chinese/\xe6\x89\x80\xe6\x9c\x89\xe4\xb8\xad\xe6"
+                         L"\x96\x87\xe7\xbd\x91\xe9\xa1\xb5.doc";
 #endif
   EXPECT_TRUE(net::FileURLToFilePath(GURL(WideToUTF8(utf8)), &output));
   EXPECT_EQ(std::wstring(wide), output);
 
   // Unfortunately, UTF8ToWide discards invalid UTF8 input.
 #ifdef BUG_878908_IS_FIXED
   // Test that no conversion happens if the UTF-8 input is invalid, and that
   // the input is preserved in UTF-8
   const char invalid_utf8[] = "file:///d:/Blah/\xff.doc";
   const wchar_t invalid_wide[] = L"D:\\Blah\\\xff.doc";
@@ skipping 11 matching lines @@
     L"HTTP/1.1 200 OK\n"
     L"Content-TYPE: text/html; charset=utf-8\n"
     L"Content-disposition: attachment; filename=\"download.pdf\"\n"
     L"Content-Length: 378557\n"
     L"X-Google-Google1: 314159265\n"
     L"X-Google-Google2: aaaa2:7783,bbb21:9441\n"
     L"X-Google-Google4: home\n"
     L"Transfer-Encoding: chunked\n"
     L"Set-Cookie: HEHE_AT=6666x66beef666x6-66xx6666x66; Path=/mail\n"
     L"Set-Cookie: HEHE_HELP=owned:0;Path=/\n"
-    L"Set-Cookie: S=gmail=Xxx-beefbeefbeef_beefb:gmail_yj=beefbeef000beefbeefbee:gmproxy=bee-fbeefbe; Domain=.google.com; Path=/\n"
+    L"Set-Cookie: S=gmail=Xxx-beefbeefbeef_beefb:gmail_yj=beefbeef000beefbee"
+        L"fbee:gmproxy=bee-fbeefbe; Domain=.google.com; Path=/\n"
     L"X-Google-Google2: /one/two/three/four/five/six/seven-height/nine:9411\n"
     L"Server: GFE/1.3\n"
     L"Transfer-Encoding: chunked\n"
     L"Date: Mon, 13 Nov 2006 21:38:09 GMT\n"
     L"Expires: Tue, 14 Nov 2006 19:23:58 GMT\n"
     L"X-Malformed: bla; arg=test\"\n"
     L"X-Malformed2: bla; arg=\n"
     L"X-Test: bla; arg1=val1; arg2=val2";
 
 TEST(NetUtilTest, GetSpecificHeader) {
@@ skipping 62 matching lines @@
     {"content-disposition: attachment; filename=abc,de.pdf", L"abc,de.pdf"},
     {"content-disposition: filename=abcde.pdf", L"abcde.pdf"},
     {"content-disposition: filename= abcde.pdf", L"abcde.pdf"},
     {"content-disposition: filename =abcde.pdf", L"abcde.pdf"},
     {"content-disposition: filename = abcde.pdf", L"abcde.pdf"},
     {"content-disposition: filename\t=abcde.pdf", L"abcde.pdf"},
     {"content-disposition: filename \t\t  =abcde.pdf", L"abcde.pdf"},
     {"content-disposition: name=abcde.pdf", L"abcde.pdf"},
     {"content-disposition: inline; filename=\"abc%20de.pdf\"", L"abc de.pdf"},
     // Whitespaces are converted to a space.
-    {"content-disposition: inline; filename=\"abc  \t\nde.pdf\"", L"abc    de.pdf"},
+    {"content-disposition: inline; filename=\"abc  \t\nde.pdf\"",
+     L"abc    de.pdf"},
     // %-escaped UTF-8
     {"Content-Disposition: attachment; filename=\"%EC%98%88%EC%88%A0%20"
      "%EC%98%88%EC%88%A0.jpg\"", L"\xc608\xc220 \xc608\xc220.jpg"},
     {"Content-Disposition: attachment; filename=\"%F0%90%8C%B0%F0%90%8C%B1"
      "abc.jpg\"", L"\U00010330\U00010331abc.jpg"},
     {"Content-Disposition: attachment; filename=\"%EC%98%88%EC%88%A0 \n"
      "%EC%98%88%EC%88%A0.jpg\"", L"\xc608\xc220  \xc608\xc220.jpg"},
     // RFC 2047 with various charsets and Q/B encodings
     {"Content-Disposition: attachment; filename=\"=?EUC-JP?Q?=B7=DD=BD="
      "D13=2Epng?=\"", L"\x82b8\x8853" L"3.png"},
@@ skipping 259 matching lines @@
       false, false, false, false, false,
       false}},
     // <Greek rho><Cyrillic a><Cyrillic u>.ru
     {"xn--2xa6t2b.ru", L"\x03c1\x0430\x0443.ru",
      {false, false, false, false, false,
       false, false, false, false, false,
       false, false, false, false, false,
       false, false, false, false, false,
       false}},
     // One that's really long that will force a buffer realloc
-    {"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-     L"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    {"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+         "aaaaaaa",
+     L"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+         L"aaaaaaaa",
      {true,  true,  true,  true,  true,
       true,  true,  true,  true,  true,
       true,  true,  true,  true,  true,
       true,  true,  true,  true,  true,
       true}},
     // Test cases for characters we blacklisted although allowed in IDN.
     // Embedded spaces will be turned to %20 in the display.
     // TODO(jungshik): We need to have more cases. This is a typical
     // data-driven trap. The following test cases need to be separated
     // and tested only for a couple of languages.
@@ skipping 170 matching lines @@
   const GetDirectoryListingEntryCase test_cases[] = {
     {"Foo",
      false,
      10000,
      base::Time(),
      "<script>addRow(\"Foo\",\"Foo\",0,\"9.8 kB\",\"\");</script>\n"},
     {"quo\"tes",
      false,
      10000,
      base::Time(),
-     "<script>addRow(\"quo\\\"tes\",\"quo%22tes\",0,\"9.8 kB\",\"\");</script>\n"},
+     "<script>addRow(\"quo\\\"tes\",\"quo%22tes\",0,\"9.8 kB\",\"\");</script>"
+         "\n"},
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     const std::string results = net::GetDirectoryListingEntry(
         test_cases[i].name,
         test_cases[i].is_dir,
         test_cases[i].filesize,
         test_cases[i].time);
     EXPECT_EQ(test_cases[i].expected, results);
   }
@@ skipping 81 matching lines @@
   }
 }
 
 TEST(NetUtilTest, GetMyHostName) {
   // We can't check the result of GetMyHostName() directly, since the result
   // will differ across machines. Our goal here is to simply exercise the
   // code path, and check that things "look about right".
   std::string my_hostname = net::GetMyHostName();
   EXPECT_FALSE(my_hostname.empty());
 }