Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 4200009: Clear JS function result caches in all global contexts. (Closed)

Created:
10 years, 1 month ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clear JS function result caches in all global contexts. Original patch by Mark Lam <mark.lam@palm.com>; from Hewlett-Packard Development Company, LP. (http://codereview.chromium.org/4187007) Fix memory corruption in JSFunctionResultCache::Clear caused by out of bounds writes which was revealed by the patch. Committed: http://code.google.com/p/v8/source/detail?r=5738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/heap.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 1 month ago (2010-10-28 19:46:54 UTC) #1
Mads Ager (chromium)
10 years, 1 month ago (2010-10-29 06:53:24 UTC) #2
LGTM

Please port to branches.

Powered by Google App Engine
This is Rietveld 408576698