DescriptionThis patch fixes Heap::ClearJSFunctionResultCaches() the same way
that Heap::ClearNormalizedMapCache() was implemented in r5654.
The existing code effectively does not clear the JSFunctionResultCaches
at all. With this patch, the caches are now cleared during a GC.
This patch has been tested by running tools/test.py.
There is only one failure:
obj/test/release/cctest test-api/Threading --testing_serialization_file=obj/test/release/serdes_Threading
However, the failure is due to Heap::ClearNormalizedMapCaches()
expecting to fetch a NormalizedMapCache instance but instead gets
something that is all of the following:
HeapObject Symbol JSObject UndetectableObject AccessCheckNeeded
i.e. the Is<XXX>() test returns true for the above.
When I comment out the one line in my patch where I actually clear
the cache, the test passes again. It looks like there's a hidden
bug in the serialization code, and this patch merely exposed it
when the cache is made to be cleared as expected.
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|