Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 4187007: This patch fixes Heap::ClearJSFunctionResultCaches() the same way... (Closed)

Created:
10 years, 1 month ago by marklam
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

This patch fixes Heap::ClearJSFunctionResultCaches() the same way that Heap::ClearNormalizedMapCache() was implemented in r5654. The existing code effectively does not clear the JSFunctionResultCaches at all. With this patch, the caches are now cleared during a GC. This patch has been tested by running tools/test.py. There is only one failure: obj/test/release/cctest test-api/Threading --testing_serialization_file=obj/test/release/serdes_Threading However, the failure is due to Heap::ClearNormalizedMapCaches() expecting to fetch a NormalizedMapCache instance but instead gets something that is all of the following: HeapObject Symbol JSObject UndetectableObject AccessCheckNeeded i.e. the Is<XXX>() test returns true for the above. When I comment out the one line in my patch where I actually clear the cache, the test passes again. It looks like there's a hidden bug in the serialization code, and this patch merely exposed it when the cache is made to be cleared as expected.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/heap.cc View 1 chunk +9 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marklam
10 years, 1 month ago (2010-10-28 18:34:27 UTC) #1
Vyacheslav Egorov (Chromium)
10 years, 1 month ago (2010-10-29 08:23:51 UTC) #2
Thanks for the patch. 

Landed as http://code.google.com/p/v8/source/detail?r=5738

Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698