Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4194007: Revert "Refactor automation messages." due to mysterious problems on mac. (Closed)

Created:
10 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Nirnimesh, jam, Aaron Boodman, darin-cc_chromium.org, anantha, pam+watch_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, amit
Visibility:
Public.

Description

Revert "Refactor automation messages." due to mysterious problems on mac. This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -190 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_json.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/chrome_frame_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/extension_port_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/url_request_automation_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/tab_contents/security_style.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_constants.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/common/page_type.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/test/automation/autocomplete_edit_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/automation/automation_constants.h View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_handle_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/automation/automation_messages.h View 6 chunks +18 lines, -17 lines 0 comments Download
A + chrome/test/automation/automation_messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/automation/automation_messages_internal.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/browser_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/extension_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/extension_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/cfproxy_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_active_document.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/external_tab.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/external_tab.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome_frame/external_tab_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/plugin_url_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/automation_client_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M ipc/ipc_message_impl_macros.h View 2 chunks +1 line, -1 line 0 comments Download
M ipc/ipc_message_macros.h View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698