Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: chrome/test/automation/tab_proxy.cc

Issue 4194007: Revert "Refactor automation messages." due to mysterious problems on mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/automation/tab_proxy.h ('k') | chrome/test/automation/window_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/automation/tab_proxy.h" 5 #include "chrome/test/automation/tab_proxy.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/common/automation_messages.h"
13 #include "chrome/common/json_value_serializer.h" 12 #include "chrome/common/json_value_serializer.h"
13 #include "chrome/test/automation/automation_constants.h"
14 #include "chrome/test/automation/automation_messages.h"
14 #include "chrome/test/automation/automation_proxy.h" 15 #include "chrome/test/automation/automation_proxy.h"
15 #include "googleurl/src/gurl.h" 16 #include "googleurl/src/gurl.h"
16 17
17 TabProxy::TabProxy(AutomationMessageSender* sender, 18 TabProxy::TabProxy(AutomationMessageSender* sender,
18 AutomationHandleTracker* tracker, 19 AutomationHandleTracker* tracker,
19 int handle) 20 int handle)
20 : AutomationResourceProxy(tracker, sender, handle) { 21 : AutomationResourceProxy(tracker, sender, handle) {
21 } 22 }
22 23
23 24
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 599
599 bool succeeded = false; 600 bool succeeded = false;
600 601
601 sender_->Send(new AutomationMsg_GetSecurityState( 602 sender_->Send(new AutomationMsg_GetSecurityState(
602 0, handle_, &succeeded, security_style, ssl_cert_status, 603 0, handle_, &succeeded, security_style, ssl_cert_status,
603 insecure_content_status)); 604 insecure_content_status));
604 605
605 return succeeded; 606 return succeeded;
606 } 607 }
607 608
608 bool TabProxy::GetPageType(PageType* type) { 609 bool TabProxy::GetPageType(NavigationEntry::PageType* type) {
609 DCHECK(type); 610 DCHECK(type);
610 611
611 if (!is_valid()) 612 if (!is_valid())
612 return false; 613 return false;
613 614
614 bool succeeded = false; 615 bool succeeded = false;
615 sender_->Send(new AutomationMsg_GetPageType(0, handle_, &succeeded, type)); 616 sender_->Send(new AutomationMsg_GetPageType(0, handle_, &succeeded, type));
616 return succeeded; 617 return succeeded;
617 } 618 }
618 619
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
829 json)); 830 json));
830 } 831 }
831 832
832 void TabProxy::FirstObjectAdded() { 833 void TabProxy::FirstObjectAdded() {
833 AddRef(); 834 AddRef();
834 } 835 }
835 836
836 void TabProxy::LastObjectRemoved() { 837 void TabProxy::LastObjectRemoved() {
837 Release(); 838 Release();
838 } 839 }
OLDNEW
« no previous file with comments | « chrome/test/automation/tab_proxy.h ('k') | chrome/test/automation/window_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698