Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: webkit/blob/blob_url_request_job_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/blob/blob_storage_controller_unittest.cc ('k') | webkit/blob/deletable_file_reference.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/blob_url_request_job_unittest.cc
diff --git a/webkit/blob/blob_url_request_job_unittest.cc b/webkit/blob/blob_url_request_job_unittest.cc
index ad4ecb4d966ddf42519942a75762ac42584f1350..2fb23375ef9e1811206cb3900dc963c2ab47c09a 100644
--- a/webkit/blob/blob_url_request_job_unittest.cc
+++ b/webkit/blob/blob_url_request_job_unittest.cc
@@ -271,13 +271,13 @@ class BlobURLRequestJobTest : public testing::Test {
// Test Cases ---------------------------------------------------------------
void TestGetSimpleDataRequest() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendData(kTestData1);
TestSuccessRequest(blob_data, kTestData1);
}
void TestGetSimpleFileRequest() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendFile(temp_file1_, 0, -1, base::Time());
TestSuccessRequest(blob_data, kTestFileData1);
}
@@ -285,13 +285,13 @@ class BlobURLRequestJobTest : public testing::Test {
void TestGetNonExistentFileRequest() {
FilePath non_existent_file =
temp_file1_.InsertBeforeExtension(FILE_PATH_LITERAL("-na"));
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendFile(non_existent_file, 0, -1, base::Time());
TestErrorRequest(blob_data, 404);
}
void TestGetChangedFileRequest() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
base::Time old_time =
temp_file_modification_time1_ - base::TimeDelta::FromSeconds(10);
blob_data->AppendFile(temp_file1_, 0, 3, old_time);
@@ -299,21 +299,21 @@ class BlobURLRequestJobTest : public testing::Test {
}
void TestGetSlicedDataRequest() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendData(kTestData2, 2, 4);
std::string result(kTestData2 + 2, 4);
TestSuccessRequest(blob_data, result);
}
void TestGetSlicedFileRequest() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendFile(temp_file1_, 2, 4, temp_file_modification_time1_);
std::string result(kTestFileData1 + 2, 4);
TestSuccessRequest(blob_data, result);
}
scoped_refptr<BlobData> BuildComplicatedData(std::string* expected_result) {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->AppendData(kTestData1, 1, 2);
blob_data->AppendFile(temp_file1_, 2, 3, temp_file_modification_time1_);
blob_data->AppendData(kTestData2, 3, 4);
@@ -356,7 +356,7 @@ class BlobURLRequestJobTest : public testing::Test {
}
void TestExtraHeaders() {
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
blob_data->set_content_type(kTestContentType);
blob_data->set_content_disposition(kTestContentDisposition);
blob_data->AppendData(kTestData1);
« no previous file with comments | « webkit/blob/blob_storage_controller_unittest.cc ('k') | webkit/blob/deletable_file_reference.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698