Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: webkit/blob/blob_storage_controller_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/blob/blob_storage_controller.cc ('k') | webkit/blob/blob_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/blob_storage_controller_unittest.cc
diff --git a/webkit/blob/blob_storage_controller_unittest.cc b/webkit/blob/blob_storage_controller_unittest.cc
index e977585ebc3a51173bfd8e0c028d975423a602d0..6d6f0d120d74559b76a9574b4bf5f2b2d0c9ba29 100644
--- a/webkit/blob/blob_storage_controller_unittest.cc
+++ b/webkit/blob/blob_storage_controller_unittest.cc
@@ -21,19 +21,19 @@ TEST(BlobStorageControllerTest, RegisterBlobUrl) {
base::Time::FromString(L"Tue, 15 Nov 1994, 12:45:26 GMT", &time1);
base::Time::FromString(L"Mon, 14 Nov 1994, 11:30:49 GMT", &time2);
- scoped_refptr<BlobData> blob_data1 = new BlobData();
+ scoped_refptr<BlobData> blob_data1(new BlobData());
blob_data1->AppendData("Data1");
blob_data1->AppendData("Data2");
blob_data1->AppendFile(FilePath(FILE_PATH_LITERAL("File1.txt")),
10, 1024, time1);
- scoped_refptr<BlobData> blob_data2 = new BlobData();
+ scoped_refptr<BlobData> blob_data2(new BlobData());
blob_data2->AppendData("Data3");
blob_data2->AppendBlob(GURL("blob://url_1"), 8, 100);
blob_data2->AppendFile(FilePath(FILE_PATH_LITERAL("File2.txt")),
0, 20, time2);
- scoped_refptr<BlobData> canonicalized_blob_data2 = new BlobData();
+ scoped_refptr<BlobData> canonicalized_blob_data2(new BlobData());
canonicalized_blob_data2->AppendData("Data3");
canonicalized_blob_data2->AppendData("Data2", 3, 2);
canonicalized_blob_data2->AppendFile(FilePath(FILE_PATH_LITERAL("File1.txt")),
@@ -86,7 +86,7 @@ TEST(BlobStorageControllerTest, ResolveBlobReferencesInUploadData) {
scoped_ptr<BlobStorageController> blob_storage_controller(
new BlobStorageController());
- scoped_refptr<BlobData> blob_data = new BlobData();
+ scoped_refptr<BlobData> blob_data(new BlobData());
GURL blob_url0("blob://url_0");
blob_storage_controller->RegisterBlobUrl(blob_url0, blob_data);
@@ -122,7 +122,7 @@ TEST(BlobStorageControllerTest, ResolveBlobReferencesInUploadData) {
FilePath(FILE_PATH_LITERAL("foo1.txt")), 0, 20, time2);
// Test no blob reference.
- scoped_refptr<UploadData> upload_data = new UploadData();
+ scoped_refptr<UploadData> upload_data(new UploadData());
upload_data->AppendBytes(
&upload_element1.bytes().at(0),
upload_element1.bytes().size());
« no previous file with comments | « webkit/blob/blob_storage_controller.cc ('k') | webkit/blob/blob_url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698