Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: webkit/appcache/appcache_update_job.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_unittest.cc ('k') | webkit/appcache/appcache_update_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_update_job.cc
diff --git a/webkit/appcache/appcache_update_job.cc b/webkit/appcache/appcache_update_job.cc
index 3aeb4976976967f66d8d9258f17478e6f2d283e0..94d8a05a7f37297079b6002d17ab757c793e212e 100644
--- a/webkit/appcache/appcache_update_job.cc
+++ b/webkit/appcache/appcache_update_job.cc
@@ -353,9 +353,9 @@ void AppCacheUpdateJob::OnResponseStarted(URLRequest *request) {
service_->storage()->CreateResponseWriter(manifest_url_),
this, request);
stored_response_ids_.push_back(info->response_writer_->response_id());
- scoped_refptr<HttpResponseInfoIOBuffer> io_buffer =
+ scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
new HttpResponseInfoIOBuffer(
- new net::HttpResponseInfo(request->response_info()));
+ new net::HttpResponseInfo(request->response_info())));
info->response_writer_->WriteInfo(io_buffer, &info->write_callback_);
} else {
ReadResponseData(request);
@@ -782,8 +782,8 @@ void AppCacheUpdateJob::HandleManifestRefetchCompleted(URLRequest* request) {
manifest_response_writer_.reset(
service_->storage()->CreateResponseWriter(manifest_url_));
stored_response_ids_.push_back(manifest_response_writer_->response_id());
- scoped_refptr<HttpResponseInfoIOBuffer> io_buffer =
- new HttpResponseInfoIOBuffer(manifest_response_info_.release());
+ scoped_refptr<HttpResponseInfoIOBuffer> io_buffer(
+ new HttpResponseInfoIOBuffer(manifest_response_info_.release()));
manifest_response_writer_->WriteInfo(io_buffer,
&manifest_info_write_callback_);
}
@@ -798,8 +798,8 @@ void AppCacheUpdateJob::HandleManifestRefetchCompleted(URLRequest* request) {
void AppCacheUpdateJob::OnManifestInfoWriteComplete(int result) {
if (result > 0) {
- scoped_refptr<net::StringIOBuffer> io_buffer =
- new net::StringIOBuffer(manifest_data_);
+ scoped_refptr<net::StringIOBuffer> io_buffer(
+ new net::StringIOBuffer(manifest_data_));
manifest_response_writer_->WriteData(io_buffer, manifest_data_.length(),
&manifest_data_write_callback_);
} else {
« no previous file with comments | « webkit/appcache/appcache_unittest.cc ('k') | webkit/appcache/appcache_update_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698