Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: webkit/appcache/appcache_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_storage_unittest.cc ('k') | webkit/appcache/appcache_update_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_unittest.cc
diff --git a/webkit/appcache/appcache_unittest.cc b/webkit/appcache/appcache_unittest.cc
index 8fcde531960ab53c0e13ac399c43a591e5ef50bd..d0583f8e4ff630279e96ea7898882f7f8285ab35 100644
--- a/webkit/appcache/appcache_unittest.cc
+++ b/webkit/appcache/appcache_unittest.cc
@@ -34,7 +34,7 @@ TEST(AppCacheTest, CleanupUnusedCache) {
TEST(AppCacheTest, AddModifyRemoveEntry) {
MockAppCacheService service;
- scoped_refptr<AppCache> cache = new AppCache(&service, 111);
+ scoped_refptr<AppCache> cache(new AppCache(&service, 111));
EXPECT_TRUE(cache->entries().empty());
EXPECT_EQ(0L, cache->cache_size());
@@ -79,7 +79,7 @@ TEST(AppCacheTest, AddModifyRemoveEntry) {
TEST(AppCacheTest, InitializeWithManifest) {
MockAppCacheService service;
- scoped_refptr<AppCache> cache = new AppCache(&service, 1234);
+ scoped_refptr<AppCache> cache(new AppCache(&service, 1234));
EXPECT_TRUE(cache->fallback_namespaces_.empty());
EXPECT_TRUE(cache->online_whitelist_namespaces_.empty());
EXPECT_FALSE(cache->online_whitelist_all_);
@@ -144,7 +144,7 @@ TEST(AppCacheTest, FindResponseForRequest) {
FallbackNamespace(kFallbackNamespaceUrl2, kFallbackEntryUrl2));
// Create a cache with some namespaces and entries.
- scoped_refptr<AppCache> cache = new AppCache(&service, 1234);
+ scoped_refptr<AppCache> cache(new AppCache(&service, 1234));
cache->InitializeWithManifest(&manifest);
cache->AddEntry(
kFallbackEntryUrl1,
« no previous file with comments | « webkit/appcache/appcache_storage_unittest.cc ('k') | webkit/appcache/appcache_update_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698