Issue 418019: Pull in icu@32651:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418019: Pull in icu@32651:... (Closed)

Created:
11 years, 1 month ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pull in icu@32651: Remove invuca.icu table from the ICU data file again(see http://codereview.chromium.org/399089/show) It was added to make Chrome not crash with a webkit patch for bug 30437 (https://bugs.webkit.org/show_bug.cgi?id=30437) However, the webkit patch was rolled back so that we don't need invuca.icu for now. Removing it will cut down the data size by 230k (before compression and in the Chrome executable on Linux/Mac and the ICU data dll on Linux). This has to be added back when it becomes necessary again to fix the aforementioned webkit bug. See also http://crbug.com/28132 (a bug about ~ 4kB of space wasted by copyright statements) BUG=20406 TEST=All the webkit tests pass. http://src.chromium.org/viewvc/chrome?view=rev&revision=33118

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download