Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 4169001: Rewritten parts of NetworkLibrary to work around memory corruption that prev... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/network_screen_browsertest.cc
===================================================================
--- chrome/browser/chromeos/login/network_screen_browsertest.cc (revision 64441)
+++ chrome/browser/chromeos/login/network_screen_browsertest.cc (working copy)
@@ -182,9 +182,9 @@
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, wifi_connecting())
.WillOnce((Return(true)));
- WifiNetwork wifi;
+ scoped_ptr<WifiNetwork> wifi(new WifiNetwork());
EXPECT_CALL(*mock_network_library_, wifi_network())
- .WillOnce(ReturnRef(wifi));
+ .WillOnce(Return(wifi.get()));
network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
@@ -223,9 +223,9 @@
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, cellular_connecting())
.WillOnce((Return(true)));
- CellularNetwork cellular;
+ scoped_ptr<CellularNetwork> cellular(new CellularNetwork());
EXPECT_CALL(*mock_network_library_, cellular_network())
- .WillOnce(ReturnRef(cellular));
+ .WillOnce(Return(cellular.get()));
network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
@@ -262,9 +262,9 @@
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, wifi_connecting())
.WillOnce((Return(true)));
- WifiNetwork wifi;
+ scoped_ptr<WifiNetwork> wifi(new WifiNetwork());
EXPECT_CALL(*mock_network_library_, wifi_network())
- .WillOnce(ReturnRef(wifi));
+ .WillOnce(Return(wifi.get()));
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(false));
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698