Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 4169001: Rewritten parts of NetworkLibrary to work around memory corruption that prev... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "app/combobox_model.h" 7 #include "app/combobox_model.h"
8 #include "app/l10n_util.h" 8 #include "app/l10n_util.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 175 EXPECT_CALL(*mock_network_library_, ethernet_connected())
176 .WillOnce((Return(false))); 176 .WillOnce((Return(false)));
177 EXPECT_CALL(*mock_network_library_, wifi_connected()) 177 EXPECT_CALL(*mock_network_library_, wifi_connected())
178 .WillOnce((Return(false))); 178 .WillOnce((Return(false)));
179 EXPECT_CALL(*mock_network_library_, cellular_connected()) 179 EXPECT_CALL(*mock_network_library_, cellular_connected())
180 .WillOnce((Return(false))); 180 .WillOnce((Return(false)));
181 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 181 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
182 .WillOnce((Return(false))); 182 .WillOnce((Return(false)));
183 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 183 EXPECT_CALL(*mock_network_library_, wifi_connecting())
184 .WillOnce((Return(true))); 184 .WillOnce((Return(true)));
185 WifiNetwork wifi; 185 scoped_ptr<WifiNetwork> wifi(new WifiNetwork());
186 EXPECT_CALL(*mock_network_library_, wifi_network()) 186 EXPECT_CALL(*mock_network_library_, wifi_network())
187 .WillOnce(ReturnRef(wifi)); 187 .WillOnce(Return(wifi.get()));
188 188
189 network_screen->NetworkChanged(mock_network_library_); 189 network_screen->NetworkChanged(mock_network_library_);
190 EXPECT_FALSE(network_view->IsContinueEnabled()); 190 EXPECT_FALSE(network_view->IsContinueEnabled());
191 EXPECT_FALSE(network_view->IsConnecting()); 191 EXPECT_FALSE(network_view->IsConnecting());
192 192
193 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 193 EXPECT_CALL(*mock_network_library_, ethernet_connected())
194 .WillOnce(Return(true)); 194 .WillOnce(Return(true));
195 EXPECT_CALL(*mock_network_library_, Connected()) 195 EXPECT_CALL(*mock_network_library_, Connected())
196 .WillOnce(Return(true)); 196 .WillOnce(Return(true));
197 197
(...skipping 18 matching lines...) Expand all
216 EXPECT_CALL(*mock_network_library_, wifi_connected()) 216 EXPECT_CALL(*mock_network_library_, wifi_connected())
217 .WillOnce((Return(false))); 217 .WillOnce((Return(false)));
218 EXPECT_CALL(*mock_network_library_, cellular_connected()) 218 EXPECT_CALL(*mock_network_library_, cellular_connected())
219 .WillOnce((Return(false))); 219 .WillOnce((Return(false)));
220 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 220 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
221 .WillOnce((Return(false))); 221 .WillOnce((Return(false)));
222 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 222 EXPECT_CALL(*mock_network_library_, wifi_connecting())
223 .WillOnce((Return(false))); 223 .WillOnce((Return(false)));
224 EXPECT_CALL(*mock_network_library_, cellular_connecting()) 224 EXPECT_CALL(*mock_network_library_, cellular_connecting())
225 .WillOnce((Return(true))); 225 .WillOnce((Return(true)));
226 CellularNetwork cellular; 226 scoped_ptr<CellularNetwork> cellular(new CellularNetwork());
227 EXPECT_CALL(*mock_network_library_, cellular_network()) 227 EXPECT_CALL(*mock_network_library_, cellular_network())
228 .WillOnce(ReturnRef(cellular)); 228 .WillOnce(Return(cellular.get()));
229 229
230 network_screen->NetworkChanged(mock_network_library_); 230 network_screen->NetworkChanged(mock_network_library_);
231 EXPECT_FALSE(network_view->IsContinueEnabled()); 231 EXPECT_FALSE(network_view->IsContinueEnabled());
232 EXPECT_FALSE(network_view->IsConnecting()); 232 EXPECT_FALSE(network_view->IsConnecting());
233 233
234 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 234 EXPECT_CALL(*mock_network_library_, ethernet_connected())
235 .WillOnce(Return(true)); 235 .WillOnce(Return(true));
236 EXPECT_CALL(*mock_network_library_, Connected()) 236 EXPECT_CALL(*mock_network_library_, Connected())
237 .WillOnce(Return(true)); 237 .WillOnce(Return(true));
238 238
(...skipping 16 matching lines...) Expand all
255 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 255 EXPECT_CALL(*mock_network_library_, ethernet_connected())
256 .WillOnce((Return(false))); 256 .WillOnce((Return(false)));
257 EXPECT_CALL(*mock_network_library_, wifi_connected()) 257 EXPECT_CALL(*mock_network_library_, wifi_connected())
258 .WillOnce((Return(false))); 258 .WillOnce((Return(false)));
259 EXPECT_CALL(*mock_network_library_, cellular_connected()) 259 EXPECT_CALL(*mock_network_library_, cellular_connected())
260 .WillOnce((Return(false))); 260 .WillOnce((Return(false)));
261 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 261 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
262 .WillOnce((Return(false))); 262 .WillOnce((Return(false)));
263 EXPECT_CALL(*mock_network_library_, wifi_connecting()) 263 EXPECT_CALL(*mock_network_library_, wifi_connecting())
264 .WillOnce((Return(true))); 264 .WillOnce((Return(true)));
265 WifiNetwork wifi; 265 scoped_ptr<WifiNetwork> wifi(new WifiNetwork());
266 EXPECT_CALL(*mock_network_library_, wifi_network()) 266 EXPECT_CALL(*mock_network_library_, wifi_network())
267 .WillOnce(ReturnRef(wifi)); 267 .WillOnce(Return(wifi.get()));
268 EXPECT_CALL(*mock_network_library_, Connected()) 268 EXPECT_CALL(*mock_network_library_, Connected())
269 .WillOnce(Return(false)); 269 .WillOnce(Return(false));
270 270
271 network_screen->NetworkChanged(mock_network_library_); 271 network_screen->NetworkChanged(mock_network_library_);
272 EXPECT_FALSE(network_view->IsContinueEnabled()); 272 EXPECT_FALSE(network_view->IsContinueEnabled());
273 EXPECT_FALSE(network_view->IsConnecting()); 273 EXPECT_FALSE(network_view->IsConnecting());
274 274
275 network_screen->OnConnectionTimeout(); 275 network_screen->OnConnectionTimeout();
276 EXPECT_FALSE(network_view->IsContinueEnabled()); 276 EXPECT_FALSE(network_view->IsContinueEnabled());
277 EXPECT_FALSE(network_view->IsConnecting()); 277 EXPECT_FALSE(network_view->IsConnecting());
278 278
279 // Close infobubble with error message - it makes test stable. 279 // Close infobubble with error message - it makes test stable.
280 network_screen->ClearErrors(); 280 network_screen->ClearErrors();
281 } 281 }
282 282
283 } // namespace chromeos 283 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698