Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 4156003: Exclude fake crash reporter directories from report. (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Exclude fake crash reporter directories from report. Change-Id: I11357f7196b66f3e879e68efa5366af115f3992b BUG=8192 TEST=Ran it with results from a test with crash reports in it. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8860e4

Patch Set 1 #

Patch Set 2 : ws #

Patch Set 3 : Remove re hack #

Patch Set 4 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M generate_test_report.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
10 years, 1 month ago (2010-10-26 21:22:20 UTC) #1
petkov
LGTM, although this is kind of ugly..
10 years, 1 month ago (2010-10-26 21:24:54 UTC) #2
sosa
My pride was offended by your "is ugly" comment. Tried to make prettier, PTAL
10 years, 1 month ago (2010-10-26 21:34:42 UTC) #3
petkov
10 years, 1 month ago (2010-10-26 21:36:06 UTC) #4
LGTM -- almost beautiful now :-)

Powered by Google App Engine
This is Rietveld 408576698