generate_test_report.py - Issue 4156003: Exclude fake crash reporter directories from report.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: generate_test_report.py

Issue 4156003: Exclude fake crash reporter directories from report. (Closed) Base URL: http://git.chromium.org/git/crosutils.git

Patch Set: Remove comment Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: generate_test_report.py

diff --git a/generate_test_report.py b/generate_test_report.py

index 97c3ec6f0da48e921caaa4eb2c11774ed3d84573..f152a61a7468d34e09012bb58f44faa4aed3d8bf 100755

--- a/generate_test_report.py

+++ b/generate_test_report.py

@@ -98,6 +98,10 @@ class ReportGenerator(object):

if not os.path.isfile(status_file):

return

+ # Remove false positives that are missing a debug dir.

+ if not os.path.exists(os.path.join(testdir, 'debug')):

+ return

status_raw = open(status_file, 'r').read()

status = 'FAIL'

if (re.search(r'GOOD.+completed successfully', status_raw) and

« no previous file with comments | « no previous file | no next file » | no next file with comments »