Issue 4154004: Fix custom_deps, hooks and custom_vars to be evaluated even if no DEPS file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4154004: Fix custom_deps, hooks and custom_vars to be evaluated even if no DEPS file. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel, Rico

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix custom_deps, hooks and custom_vars to be evaluated even if no DEPS file. Previously, solution's properties would be ignored if there was no DEPS file in source control. Change the behavior to evaluate the properties anyway. TEST=new smoke test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64232

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -16 lines)			Patch
	M	gclient.py	View		4 chunks	+15 lines, -16 lines	0 comments	Download
	M	tests/gclient_smoketest.py	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Adding Jochen because he's in the right time zone. Adding Rico FYI. Dependent on http://codereview.chromium.org/4215001

10 years, 1 month ago (2010-10-28 11:16:41 UTC) #1

lgtm

Expand Messages | Collapse Messages