Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1627)

Unified Diff: tests/gclient_smoketest.py

Issue 4154004: Fix custom_deps, hooks and custom_vars to be evaluated even if no DEPS file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_smoketest.py
diff --git a/tests/gclient_smoketest.py b/tests/gclient_smoketest.py
index 17269b547bece287267f2d1bc7a91a107392bc9a..551581a1cd5c56d875b860ab8000771d28b6c509 100755
--- a/tests/gclient_smoketest.py
+++ b/tests/gclient_smoketest.py
@@ -434,6 +434,34 @@ class GClientSmokeSVN(GClientSmokeBase):
tree['src/svn_hooked1'] = 'svn_hooked1'
self.assertTree(tree)
+ def testSyncCustomDepsNoDeps(self):
+ if not self.enabled:
+ return
+ out = (
+ 'solutions = [\n'
+ # This directory has no DEPS file.
+ ' { "name" : "src/third_party",\n'
+ ' "url" : "%(base)s/src/third_party",\n'
+ ' "custom_deps" : {\n'
+ # Add 1.
+ ' "src/other": \'/trunk/other\',\n'
+ ' },\n'
+ ' "safesync_url": "",\n'
+ ' },\n'
+ ']\n\n' %
+ { 'base': self.svn_base + 'trunk' })
+ fileobj = open(os.path.join(self.root_dir, '.gclient'), 'w')
+ fileobj.write(out)
+ fileobj.close()
+ self.parseGclient(
+ ['sync', '--deps', 'mac', '--jobs', '1'],
+ ['running', 'running'],
+ untangle=True)
+ tree = self.mangle_svn_tree(
+ ('trunk/src/third_party@2', 'src/third_party'),
+ ('trunk/other@2', 'src/other'))
+ self.assertTree(tree)
+
def testRevertAndStatus(self):
if not self.enabled:
return
« no previous file with comments | « gclient.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698