Make Parser class have no friends and fewer things to depend on it.

Make Parser class have no friends and fewer things to depend on it.

[Lasse Reichstein, 2010-10-27 12:16:13]

No new functionality, refactoring only.

[Mads Ager (chromium), 2010-10-27 12:24:18]

LGTM

http://codereview.chromium.org/4146006/diff/1/6
File src/parser.cc (left):

http://codereview.chromium.org/4146006/diff/1/6#oldcode1
src/parser.cc:1: // Copyright 2010 the V8 project authors. All rights reserved.
Whoops.

http://codereview.chromium.org/4146006/diff/1/7
File src/parser.h (right):

http://codereview.chromium.org/4146006/diff/1/7#newcode201
src/parser.h:201: class BufferedZoneList {
Could you add a comment here about the buffering nature? I know you just moved
this code, but a class comment would be nice.

http://codereview.chromium.org/4146006/diff/1/7#newcode226
src/parser.h:226: if (list_ != NULL && list_->length() > 0)
Please uses braces.

http://codereview.chromium.org/4146006/diff/1/7#newcode288
src/parser.h:288: private:
Could you add a blank line before "private:"

[Lasse Reichstein, 2010-10-27 12:32:51]

http://codereview.chromium.org/4146006/diff/1/6
File src/parser.cc (left):

http://codereview.chromium.org/4146006/diff/1/6#oldcode1
src/parser.cc:1: // Copyright 2010 the V8 project authors. All rights reserved.
Indeed.
A local equivalent of this code-review tool would be great :)

http://codereview.chromium.org/4146006/diff/1/7
File src/parser.h (right):

http://codereview.chromium.org/4146006/diff/1/7#newcode201
src/parser.h:201: class BufferedZoneList {
Done.

http://codereview.chromium.org/4146006/diff/1/7#newcode226
src/parser.h:226: if (list_ != NULL && list_->length() > 0)
Done.

http://codereview.chromium.org/4146006/diff/1/7#newcode288
src/parser.h:288: private:
Done.