Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/liveedit.cc

Issue 4146006: Make Parser class have no friends and fewer things to depend on it. (Closed)
Patch Set: Addressed review comments. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/jsregexp.cc ('k') | src/parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 } 397 }
398 398
399 399
400 static void CompileScriptForTracker(Handle<Script> script) { 400 static void CompileScriptForTracker(Handle<Script> script) {
401 // TODO(635): support extensions. 401 // TODO(635): support extensions.
402 PostponeInterruptsScope postpone; 402 PostponeInterruptsScope postpone;
403 403
404 // Build AST. 404 // Build AST.
405 CompilationInfo info(script); 405 CompilationInfo info(script);
406 info.MarkAsGlobal(); 406 info.MarkAsGlobal();
407 if (Parser::Parse(&info)) { 407 if (ParserApi::Parse(&info)) {
408 // Compile the code. 408 // Compile the code.
409 LiveEditFunctionTracker tracker(info.function()); 409 LiveEditFunctionTracker tracker(info.function());
410 if (Compiler::MakeCodeForLiveEdit(&info)) { 410 if (Compiler::MakeCodeForLiveEdit(&info)) {
411 ASSERT(!info.code().is_null()); 411 ASSERT(!info.code().is_null());
412 tracker.RecordRootFunctionInfo(info.code()); 412 tracker.RecordRootFunctionInfo(info.code());
413 } else { 413 } else {
414 Top::StackOverflow(); 414 Top::StackOverflow();
415 } 415 }
416 } 416 }
417 } 417 }
(...skipping 1056 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 1474
1475 bool LiveEditFunctionTracker::IsActive() { 1475 bool LiveEditFunctionTracker::IsActive() {
1476 return false; 1476 return false;
1477 } 1477 }
1478 1478
1479 #endif // ENABLE_DEBUGGER_SUPPORT 1479 #endif // ENABLE_DEBUGGER_SUPPORT
1480 1480
1481 1481
1482 1482
1483 } } // namespace v8::internal 1483 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/jsregexp.cc ('k') | src/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698