Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 4132002: Fix retry mechanism to raise when it fails to checkout. (Closed)

Created:
10 years, 2 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix retry mechanism to raise when it fails to checkout. TBR=jochen BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63832

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M scm.py View 2 chunks +5 lines, -1 line 2 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 2 months ago (2010-10-26 00:57:08 UTC) #1
jochen (gone - plz use gerrit)
10 years, 1 month ago (2010-10-26 09:29:03 UTC) #2
http://codereview.chromium.org/4132002/diff/1/2
File scm.py (right):

http://codereview.chromium.org/4132002/diff/1/2#newcode1
scm.py:1: # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
nit. non-std copyright header

http://codereview.chromium.org/4132002/diff/1/2#newcode354
scm.py:354: i = 0
maybe use a more descriptive variable name, and similar to backoff_time put the
maximum number of retries in a variable?

Powered by Google App Engine
This is Rietveld 408576698