Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: scm.py

Issue 4132002: Fix retry mechanism to raise when it fails to checkout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 00364cae4c82f2bf181db2f5ffca83626857a518..ac674d695a88e50e53e26730e37d6622ad71d4f3 100644
--- a/scm.py
+++ b/scm.py
@@ -351,7 +351,9 @@ class SVN(object):
compiled_pattern = re.compile(pattern)
# Place an upper limit.
backoff_time = 5
- for _ in range(10):
+ i = 0
jochen (gone - plz use gerrit) 2010/10/26 09:29:03 maybe use a more descriptive variable name, and si
+ while True:
+ i += 1
previous_list_len = len(file_list)
failure = []
@@ -404,6 +406,8 @@ class SVN(object):
if len(file_list) == previous_list_len and not IsKnownFailure():
# No known svn error was found and no progress, bail out.
raise
+ if i == 10:
+ raise
print "Sleeping %.1f seconds and retrying...." % backoff_time
time.sleep(backoff_time)
backoff_time *= 1.3
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698