Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 4127014: Blacklist more characters when sending a try job. (Closed)

Created:
10 years, 1 month ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel, jam
Visibility:
Public.

Description

Blacklist more characters when sending a try job. Otherwise files containing these characters can be created on the file system, making it harder to get rid of those files. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use whitelist instead of blacklist, fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tests/trychange_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M trychange.py View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
10 years, 1 month ago (2010-11-01 19:44:59 UTC) #1
M-A Ruel
Adding Jochen, whoever is the faster to review. :)
10 years, 1 month ago (2010-11-02 13:51:47 UTC) #2
jochen (gone - plz use gerrit)
http://codereview.chromium.org/4127014/diff/1/2 File trychange.py (right): http://codereview.chromium.org/4127014/diff/1/2#newcode98 trychange.py:98: .replace(':', '-')) hum, what about a whitelist instead of ...
10 years, 1 month ago (2010-11-02 18:51:46 UTC) #3
M-A Ruel
http://codereview.chromium.org/4127014/diff/1/2 File trychange.py (right): http://codereview.chromium.org/4127014/diff/1/2#newcode98 trychange.py:98: .replace(':', '-')) On 2010/11/02 18:51:46, jochen wrote: > hum, ...
10 years, 1 month ago (2010-11-02 18:53:34 UTC) #4
M-A Ruel
Use a white list instead of a black list and fixed unit test.
10 years, 1 month ago (2010-11-02 19:12:41 UTC) #5
jochen (gone - plz use gerrit)
10 years, 1 month ago (2010-11-02 19:12:50 UTC) #6
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698