Blacklist more characters when sending a try job.

trychange.py

 #!/usr/bin/python
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Client-side script to send a try job to the try server. It communicates to
 the try server by either writting to a svn repository or by directly connecting
 to the server by HTTP.
 """
 
 import datetime
@@ skipping 67 matching lines @@
 class InvalidScript(Exception):
   def __str__(self):
     return self.args[0] + '\n' + HELP_STRING
 
 
 class NoTryServerAccess(Exception):
   def __str__(self):
     return self.args[0] + '\n' + HELP_STRING
 
 
-def EscapeDot(name):
-  return name.replace('.', '-')
+def Escape(name):
+  """Escapes characters that could interfere with the file system or try job
+  parsing.
+  """
+  return re.sub(r'[^\w#-]', '_', name)
 
 
 class SCM(object):
   """Simplistic base class to implement one function: ProcessOptions."""
   def __init__(self, options, path):
     items = path.split('@')
     assert len(items) <= 2
     self.checkout_root = items[0]
     items.append(None)
     self.diff_against = items[1]
@@ skipping 271 matching lines @@
   temp_dir = tempfile.mkdtemp()
   temp_file = tempfile.NamedTemporaryFile()
   try:
     try:
       # Description
       temp_file.write(description)
       temp_file.flush()
 
       # Diff file
       current_time = str(datetime.datetime.now()).replace(':', '.')
-      file_name = (EscapeDot(options.user) + '.' + EscapeDot(options.name) +
+      file_name = (Escape(options.user) + '.' + Escape(options.name) +
                    '.%s.diff' % current_time)
       full_path = os.path.join(temp_dir, file_name)
       gclient_utils.FileWrite(full_path, options.diff, 'wb')
 
       # Committing it will trigger a try job.
       if sys.platform == "cygwin":
         # Small chromium-specific issue here:
         # git-try uses /usr/bin/python on cygwin but svn.bat will be used
         # instead of /usr/bin/svn by default. That causes bad things(tm) since
         # Windows' svn.exe has no clue about cygwin paths. Hence force to use
@@ skipping 365 matching lines @@
     print >> sys.stderr, e
     return 1
   except gclient_utils.Error, e:
     print >> sys.stderr, e
     return 1
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(TryChange(None, [], False))