Issue 4114006: AU: locate bsdiff/bspatch in $PATH, rather than hard coding their location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4114006: AU: locate bsdiff/bspatch in $PATH, rather than hard coding their location. (Closed)

Created:
10 years, 1 month ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

AU: locate bsdiff/bspatch in $PATH, rather than hard coding their location. BUG=8484 TEST=overloaded bs{diff,patch} with a shell script wrapper, put it early in $PATH, ran unittests, and verified my wrapper was called. Change-Id: I16c6a9cea6d7268f7a0ae423fc04c6025b18f0df Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=50f3649

Patch Set 1 #

Patch Set 2 : fix for review #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	delta_diff_generator.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	subprocess.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM although it might be good to test on the device and config /usr/bin is ...

10 years, 1 month ago (2010-11-01 19:39:46 UTC) #2

adlr

great idea! I'll do that test, then push. -andrew On Mon, Nov 1, 2010 at ...

10 years, 1 month ago (2010-11-01 19:48:50 UTC) #3

adlr

10 years, 1 month ago (2010-11-01 20:57:03 UTC) #4

found a change needed in subprocess, too. fixed it, verified on client.
submitting now...

Expand Messages | Collapse Messages