subprocess.cc - Issue 4114006: AU: locate bsdiff/bspatch in $PATH, rather than hard coding their location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess.cc

Issue 4114006: AU: locate bsdiff/bspatch in $PATH, rather than hard coding their location. (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master

Patch Set: fix for review Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess.cc

diff --git a/subprocess.cc b/subprocess.cc

index 49fc4c35c22e098413166310de5d8063b642a7e4..af5fb757a16743c425667bc8e541125c6e4b7257 100755

--- a/subprocess.cc

+++ b/subprocess.cc

@@ -162,7 +162,8 @@ bool Subprocess::SynchronousExecFlags(const std::vector<std::string>& cmd,

NULL, // working directory

argv.get(),

argp,

- static_cast<GSpawnFlags>(G_SPAWN_STDERR_TO_DEV_NULL | flags), // flags

+ static_cast<GSpawnFlags>(G_SPAWN_STDERR_TO_DEV_NULL |

+ G_SPAWN_SEARCH_PATH | flags), // flags

GRedirectStderrToStdout, // child setup function

NULL, // data for child setup function

&child_stdout,

« no previous file with comments | « delta_diff_generator.cc ('k') | no next file » | no next file with comments »