First pass at adding http/backend cache to NetLog

net/base/capturing_net_log.h

Index: net/base/capturing_net_log.h
===================================================================
--- net/base/capturing_net_log.h	(revision 68857)
+++ net/base/capturing_net_log.h	(working copy)
@@ -61,6 +61,10 @@
 
   void Clear();
 
+  // This function is not thread safe, so must only be called when the

[eroman, 2011/01/05 02:39:06]

I suggest making this threadsafe -- simply read-write log_level_ while lock_ is
held.

This keeps the API consistent, and shouldnt have a measurable performance
impact.

[mmenke, 2011/01/05 16:32:25]

Done, and renamed to SetLogLevel.

+  // CapturingNetLog is not being actively used.
+  void set_log_level(NetLog::LogLevel log_level);
+
  private:
   // Needs to be "mutable" so can use it in GetEntries().
   mutable Lock lock_;
@@ -71,6 +75,8 @@
   size_t max_num_entries_;
   EntryList entries_;
 
+  NetLog::LogLevel log_level_;
+
   DISALLOW_COPY_AND_ASSIGN(CapturingNetLog);
 };
 
@@ -97,6 +103,11 @@
 
   void Clear();
 
+  // This function is not thread safe, so must only be called when the

[eroman, 2011/01/05 02:39:06]

Ditto to comment above.

(Also note that if you do that, should change the name to SetLogLevel() since it
is no longer a simple setter).

[mmenke, 2011/01/05 16:32:25]

Done.

+  // CapturingBoundNetLog and underlying CapturingNetLog are not actively being
+  // used.
+  void set_log_level(NetLog::LogLevel log_level);
+
  private:
   NetLog::Source source_;
   scoped_ptr<CapturingNetLog> capturing_net_log_;