First pass at adding http/backend cache to NetLog

net/base/capturing_net_log.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_CAPTURING_NET_LOG_H_
 #define NET_BASE_CAPTURING_NET_LOG_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 43 matching lines @@
                         EventPhase phase,
                         EventParameters* extra_parameters);
   virtual uint32 NextID();
   virtual LogLevel GetLogLevel() const;
 
   // Returns the list of all entries in the log.
   void GetEntries(EntryList* entry_list) const;
 
   void Clear();
 
+  // This function is not thread safe, so must only be called when the

[eroman, 2011/01/05 02:39:06]

I suggest making this threadsafe -- simply read-write log_level_ while lock_ is
held.

This keeps the API consistent, and shouldnt have a measurable performance
impact.

[mmenke, 2011/01/05 16:32:25]

Done, and renamed to SetLogLevel.

+  // CapturingNetLog is not being actively used.
+  void set_log_level(NetLog::LogLevel log_level);
+
  private:
   // Needs to be "mutable" so can use it in GetEntries().
   mutable Lock lock_;
 
   // Last assigned source ID.  Incremented to get the next one.
   base::subtle::Atomic32 last_id_;
 
   size_t max_num_entries_;
   EntryList entries_;
 
+  NetLog::LogLevel log_level_;
+
   DISALLOW_COPY_AND_ASSIGN(CapturingNetLog);
 };
 
 // Helper class that exposes a similar API as BoundNetLog, but uses a
 // CapturingNetLog rather than the more generic NetLog.
 //
 // CapturingBoundNetLog can easily be converted to a BoundNetLog using the
 // bound() method.
 class CapturingBoundNetLog {
  public:
   CapturingBoundNetLog(const NetLog::Source& source, CapturingNetLog* net_log);
 
   explicit CapturingBoundNetLog(size_t max_num_entries);
 
   ~CapturingBoundNetLog();
 
   // The returned BoundNetLog is only valid while |this| is alive.
   BoundNetLog bound() const {
     return BoundNetLog(source_, capturing_net_log_.get());
   }
 
   // Fills |entry_list| with all entries in the log.
   void GetEntries(CapturingNetLog::EntryList* entry_list) const;
 
   void Clear();
 
+  // This function is not thread safe, so must only be called when the

[eroman, 2011/01/05 02:39:06]

Ditto to comment above.

(Also note that if you do that, should change the name to SetLogLevel() since it
is no longer a simple setter).

[mmenke, 2011/01/05 16:32:25]

Done.

+  // CapturingBoundNetLog and underlying CapturingNetLog are not actively being
+  // used.
+  void set_log_level(NetLog::LogLevel log_level);
+
  private:
   NetLog::Source source_;
   scoped_ptr<CapturingNetLog> capturing_net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(CapturingBoundNetLog);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_CAPTURING_NET_LOG_H_