Issue 4040: Refactoring out common code in the X.509 cert handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4040: Refactoring out common code in the X.509 cert handling (Closed)

Created:
12 years, 3 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
wtc, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactoring out common code in the X.509 cert handling Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2525

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -794 lines)			Patch
M	net/base/x509_certificate.h	View	3 chunks	+26 lines, -8 lines	1 comment	Download
A +	net/base/x509_certificate.cc	View	3 chunks	+31 lines, -468 lines	0 comments	Download
M	net/base/x509_certificate_mac.cc	View	4 chunks	+1 line, -132 lines	0 comments	Download
M	net/base/x509_certificate_win.cc	View	5 chunks	+57 lines, -185 lines	0 comments	Download
M	net/build/net.vcproj	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/net.xcodeproj/project.pbxproj	View	4 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

12 years, 3 months ago (2008-09-23 21:39:54 UTC) #3

LGTM.  Thanks!

http://codereview.chromium.org/4040/diff/1/5
File net/base/x509_certificate.h (right):

http://codereview.chromium.org/4040/diff/1/5#newcode13
Line 13: #include "base/singleton.h"
Nit: list "base/singleton.h" in alphabetical order.

Expand Messages | Collapse Messages