Refactoring out common code in the X.509 cert handling

net/base/x509_certificate.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_X509_CERTIFICATE_H_
 #define NET_BASE_X509_CERTIFICATE_H_
 
+#include <map>
 #include <set>
 #include <string>
 #include <vector>
 
+#include "base/singleton.h"

[wtc, 2008/09/23 21:39:55]

Nit: list "base/singleton.h" in alphabetical order.

 #include "base/ref_counted.h"
 #include "base/time.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <wincrypt.h>
 #elif defined(OS_MACOSX)
 #include <Security/Security.h>
 #endif
 
@@ skipping 137 matching lines @@
   bool HasExpired() const;
 
   // Returns true if the certificate is an extended-validation (EV)
   // certificate.
   bool IsEV(int cert_status) const;
 
   OSCertHandle os_cert_handle() const { return cert_handle_; }
 
  private:
   // A cache of X509Certificate objects.
-  class Cache;
+  class Cache {
+   public:
+    static Cache* GetInstance();
+    void Insert(X509Certificate* cert);
+    void Remove(X509Certificate* cert);
+    X509Certificate* Find(const Fingerprint& fingerprint);
+    
+   private:
+    typedef std::map<Fingerprint, X509Certificate*, FingerprintLessThan>
+        CertMap;
+    
+    // Obtain an instance of X509Certificate::Cache via GetInstance().
+    Cache() { }
+    friend struct DefaultSingletonTraits<Cache>;
+    
+    // You must acquire this lock before using any private data of this object.
+    // You must not block while holding this lock.
+    Lock lock_;
+    
+    // The certificate cache.  You must acquire |lock_| before using |cache_|.
+    CertMap cache_;
+    
+    DISALLOW_COPY_AND_ASSIGN(Cache);
+  };
 
   // Construct an X509Certificate from a handle to the certificate object
   // in the underlying crypto library.
   explicit X509Certificate(OSCertHandle cert_handle);
 
   friend class base::RefCountedThreadSafe<X509Certificate>;
   ~X509Certificate();
 
   // Common object initialization code.  Called by the constructors only.
   void Initialize();
 
-#if defined(OS_WIN)
-  // Helper function to parse a principal from a WinInet description of that
-  // principal.
-  static void ParsePrincipal(const std::string& description,
-                             Principal* principal);
-#endif
-
   // The subject of the certificate.
   Principal subject_;
 
   // The issuer of the certificate.
   Principal issuer_;
 
   // This certificate is not valid before |valid_start_|
   Time valid_start_;
 
   // This certificate is not valid after |valid_expiry_|
   Time valid_expiry_;
 
   // The fingerprint of this certificate.
   Fingerprint fingerprint_;
 
   // A handle to the certificate object in the underlying crypto library.
   OSCertHandle cert_handle_;
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_X509_CERTIFICATE_H_