Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 4035: Refactored the code for entering and leaving exit frames (calls... (Closed)

Created:
12 years, 3 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactored the code for entering and leaving exit frames (calls from JavaScript to C++). Includes a few slight optimizations like keeping argv in a callee-saved register. Committed: http://code.google.com/p/v8/source/detail?r=359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -113 lines) Patch
M src/builtins-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/builtins-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/codegen-arm.cc View 4 chunks +8 lines, -43 lines 1 comment Download
M src/codegen-ia32.cc View 5 chunks +8 lines, -48 lines 1 comment Download
M src/frames-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/macro-assembler-arm.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/macro-assembler-arm.cc View 2 chunks +53 lines, -1 line 0 comments Download
M src/macro-assembler-ia32.h View 2 chunks +9 lines, -3 lines 0 comments Download
M src/macro-assembler-ia32.cc View 2 chunks +53 lines, -1 line 0 comments Download
M src/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kasper Lund
12 years, 3 months ago (2008-09-23 07:42:55 UTC) #1
iposva
http://codereview.chromium.org/4035/diff/1/10 File src/codegen-arm.cc (right): http://codereview.chromium.org/4035/diff/1/10#newcode1645 Line 1645: __ mov(r1, Operand(r6)); Please add r6 to the ...
12 years, 3 months ago (2008-09-23 07:51:27 UTC) #2
Mads Ager (chromium)
12 years, 3 months ago (2008-09-23 08:08:01 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698