Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 4027: Roll the icu38 revision in the DEPS file to change the name of... (Closed)

Created:
12 years, 3 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Roll the icu38 revision in the DEPS file to change the name of our combined-build icuuc.lib to icu.lib. Change solution file references accordingly. Also change libxml patch and Makefile references Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/base.sln View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_kjs.sln View 1 chunk +1 line, -1 line 0 comments Download
M net/net.sln View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/google.patch View 1 chunk +1 line, -1 line 1 comment Download
M third_party/libxml/win32/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/win32/Makefile.msvc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.sln View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit_kjs.sln View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
LGTM (with the comment added about the icu library) http://codereview.chromium.org/4027/diff/1/5 File third_party/libxml/google.patch (right): http://codereview.chromium.org/4027/diff/1/5#newcode497 Line ...
12 years, 3 months ago (2008-09-23 01:31:25 UTC) #1
darin (slow to review)
12 years, 3 months ago (2008-09-23 05:13:59 UTC) #2
OK, LGTM

Powered by Google App Engine
This is Rietveld 408576698