Roll the icu38 revision in the DEPS file to change the name of...

third_party/libxml/google.patch

 Index: encoding.c
 ===================================================================
 --- encoding.c  (revision 3733)
 +++ encoding.c  (working copy)
 @@ -58,7 +58,7 @@
  static int xmlCharEncodingAliasesNb = 0;
  static int xmlCharEncodingAliasesMax = 0;
  
 -#ifdef LIBXML_ICONV_ENABLED
 +#if defined(LIBXML_ICONV_ENABLED) || defined(LIBXML_ICU_ENABLED)
@@ skipping 476 matching lines @@
      xmlDetectSAX2(ctxt);
 Index: win32/Makefile.msvc
 ===================================================================
 --- win32/Makefile.msvc (revision 3733)
 +++ win32/Makefile.msvc (working copy)
 @@ -71,6 +71,9 @@
  !if "$(WITH_ICONV)" == "1"
  LIBS = $(LIBS) iconv.lib
  !endif 
 ++!if "$(WITH_ICU)" == "1"
-++LIBS = $(LIBS) icuuc.lib
+++LIBS = $(LIBS) icu.lib

[jungshik at Google, 2008/09/23 01:31:26]

This change is a bit tricky when sending the patch to upstream (actually, I did
that a long while ago, but hasn't pushed hard enough to be added to libxml
trunk). For now, let's do it (perhaps with a comment about that). The same is
true of actual Makefile/Makefile.msvc

 ++!endif
  !if "$(WITH_ZLIB)" == "1"
  LIBS = $(LIBS) zdll.lib
  !endif
 Index: win32/configure.js
 ===================================================================
 --- win32/configure.js  (revision 3733)
 +++ win32/configure.js  (working copy)
 @@ -40,6 +40,7 @@
  var withXptr = true;
@@ skipping 79 matching lines @@
 +++ xmlregexp.c (working copy)
 @@ -6464,7 +6464,7 @@
      if (name != NULL) {
         value += 30 * (*name);
         while ((ch = *name++) != 0) {
 -           value = value ^ ((value << 5) + (value >> 3) + (unsigned long)ch);
 +           value = value ^ ((value << 5) + (value >> 3) + (unsigned short)ch);
         }
      }
      return (value);