gclient: fix bug in parsing ssh urls

gclient: fix bug in parsing ssh urls

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32568

[Kenneth Waters, 2009-11-19 23:34:03]

This seems reasonable to me, but
http://codf2.jail:8030/builders/x86%20Platform/builds/122 checked out fio 1.34.2
just fine.  Do you know why that might be?

[kwaters, 2009-11-19 23:45:22]

lgtm

On Thu, Nov 19, 2009 at 3:43 PM, Mandeep Baines <msb@google.com> wrote:

> On Thu, Nov 19, 2009 at 3:34 PM,  <kwaters@chromium.org> wrote:
> > This seems reasonable to me, but
> > http://codf2.jail:8030/builders/x86%20Platform/builds/122 checked out
> fio
> > 1.34.2
> > just fine.  Do you know why that might be?
> >
>
> Because its using an http url. Its only broken for ssh urls.
>
> > http://codereview.chromium.org/402105
> >
>

[kwaters, 2009-11-19 23:48:38]

Can I recommend switching to urlparse.urlparse to clean up the
scheme/username/password/url stuff.  You'll still need an re to split the
revision off but you will only have to worry about the path.

-- Kenneth Waters

On Thu, Nov 19, 2009 at 3:45 PM, Kenneth Waters <kwaters@google.com> wrote:

> lgtm
>
>
> On Thu, Nov 19, 2009 at 3:43 PM, Mandeep Baines <msb@google.com> wrote:
>
>> On Thu, Nov 19, 2009 at 3:34 PM,  <kwaters@chromium.org> wrote:
>> > This seems reasonable to me, but
>> > http://codf2.jail:8030/builders/x86%20Platform/builds/122 checked out
>> fio
>> > 1.34.2
>> > just fine.  Do you know why that might be?
>> >
>>
>> Because its using an http url. Its only broken for ssh urls.
>>
>> > http://codereview.chromium.org/402105
>> >
>>
>
>

[M-A Ruel, 2009-11-20 00:01:52]

rubberstamp lgtm